Skip to content

Bring back HNSWLIB_NO_NATIVE #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Bring back HNSWLIB_NO_NATIVE #493

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08569de
Bring back HNSWLIB_NO_NATIVE
dyashuni Aug 11, 2023
e023f7e
Fix
dyashuni Aug 11, 2023
eecd540
Rename flag, use class name to access static variables
dyashuni Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 24 additions & 20 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,19 @@ def cpp_flag(compiler):

class BuildExt(build_ext):
"""A custom build extension for adding compiler-specific options."""
compiler_flag_native = '-march=native'
c_opts = {
'msvc': ['/EHsc', '/openmp', '/O2'],
'unix': ['-O3', '-march=native'], # , '-w'
'unix': ['-O3', compiler_flag_native], # , '-w'
}
link_opts = {
'unix': [],
'msvc': [],
}

if os.environ.get("HNSWLIB_NO_NATIVE"):
c_opts['unix'].remove(compiler_flag_native)

if sys.platform == 'darwin':
c_opts['unix'] += ['-stdlib=libc++', '-mmacosx-version-min=10.7']
link_opts['unix'] += ['-stdlib=libc++', '-mmacosx-version-min=10.7']
Expand All @@ -91,35 +95,35 @@ class BuildExt(build_ext):

def build_extensions(self):
ct = self.compiler.compiler_type
opts = self.c_opts.get(ct, [])
opts = BuildExt.c_opts.get(ct, [])
if ct == 'unix':
opts.append('-DVERSION_INFO="%s"' % self.distribution.get_version())
opts.append(cpp_flag(self.compiler))
if has_flag(self.compiler, '-fvisibility=hidden'):
opts.append('-fvisibility=hidden')
# check that native flag is available
native_flag = '-march=native'
print('checking avalability of flag:', native_flag)
if not has_flag(self.compiler, native_flag):
print('removing unsupported compiler flag:', native_flag)
opts.remove(native_flag)
# for macos add apple-m1 flag if it's available
if sys.platform == 'darwin':
m1_flag = '-mcpu=apple-m1'
print('checking avalability of flag:', m1_flag)
if has_flag(self.compiler, m1_flag):
print('adding flag:', m1_flag)
opts.append(m1_flag)
else:
print(f'flag: {m1_flag} is not available')
else:
print(f'flag: {native_flag} is available')
if not os.environ.get("HNSWLIB_NO_NATIVE"):
# check that native flag is available
print('checking avalability of flag:', BuildExt.compiler_flag_native)
if not has_flag(self.compiler, BuildExt.compiler_flag_native):
print('removing unsupported compiler flag:', BuildExt.compiler_flag_native)
opts.remove(BuildExt.compiler_flag_native)
# for macos add apple-m1 flag if it's available
if sys.platform == 'darwin':
m1_flag = '-mcpu=apple-m1'
print('checking avalability of flag:', m1_flag)
if has_flag(self.compiler, m1_flag):
print('adding flag:', m1_flag)
opts.append(m1_flag)
else:
print(f'flag: {m1_flag} is not available')
else:
print(f'flag: {BuildExt.compiler_flag_native} is available')
elif ct == 'msvc':
opts.append('/DVERSION_INFO=\\"%s\\"' % self.distribution.get_version())

for ext in self.extensions:
ext.extra_compile_args.extend(opts)
ext.extra_link_args.extend(self.link_opts.get(ct, []))
ext.extra_link_args.extend(BuildExt.link_opts.get(ct, []))

build_ext.build_extensions(self)

Expand Down