Skip to content

ci: Allow skipping tests when running under CI #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2017
Merged

ci: Allow skipping tests when running under CI #588

merged 1 commit into from
Apr 17, 2017

Conversation

kamalmarhubi
Copy link
Member

This adds --cfg=travis to builds under CI, allowing tests to be
conditionally ignored by marking them with

#[cfg_attr(travis, ignore)]

refs #568

@kamalmarhubi
ci: Allow skipping tests when running under CI
25ce053 
This adds `--cfg=travis` to builds under CI, allowing tests to be
conditionally ignored by marking them with

    #[cfg_attr(travis, ignore)]

refs nix-rust#568
@kamalmarhubi kamalmarhubi requested a review from posborne April 17, 2017 03:53
@kamalmarhubi
Copy link
Member Author

r? @posborne

Does this seem reasonable to you?

@kamalmarhubi kamalmarhubi mentioned this pull request Apr 17, 2017
Merged
@kamalmarhubi
Copy link
Member Author

kamalmarhubi commented Apr 17, 2017 •
edited
Loading

In particular, setting RUSTFLAGS passes this down to all dependencies. Our transitive test dependencies right now:

  • bitflags
  • cfg-if
  • gcc
  • kernel32-sys
  • lazy_static
  • libc
  • rand
  • rustc_version
  • semver
  • tempdir
  • tempfile
  • void
  • winapi
  • winapi-build

I'm guessing travis is not likely to be tested in these crates, but pointing it out anyway.

@asomers asomers self-requested a review April 17, 2017 15:32
asomers
asomers approved these changes Apr 17, 2017
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though if anybody has an extra seven grand lying around, we can get one of these babies and ditch QEMU.

https://system76.com/servers/starling

@kamalmarhubi
Copy link
Member Author

A lesser ARM device would probably be all right for our use cases. :-)

bors r=asomers

bors bot added a commit that referenced this pull request Apr 17, 2017
@bors
Merge #588
3095f77 
588: ci: Allow skipping tests when running under CI r=asomers
This adds `--cfg=travis` to builds under CI, allowing tests to be
conditionally ignored by marking them with

    #[cfg_attr(travis, ignore)]

refs #568
@bors
Copy link
Contributor

bors bot commented Apr 17, 2017

Build succeeded

@bors bors bot merged commit 25ce053 into nix-rust:master Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

@posborne posborne Awaiting requested review from posborne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamalmarhubi @asomers