feat: I/O safety for 'sys/memfd' & 'sys/event' & 'sys/eventfd' #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
force-pushed
the
io-safety-memfd-event-eventfd
branch
from
04e0818 to
6d052a7
Compare
SteveLauC
force-pushed
the
io-safety-memfd-event-eventfd
branch
from
f93603b to
8f93634
Compare
asomers
requested changes
Dec 9, 2022
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Could you please split the formatting changes out into a separate commit?
SUPERCILEX
added a commit
to SUPERCILEX/nix
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Alex Saveau <[email protected]>
Contributor
|
Made the formatting changes here: #1935. CI checks are clearly still broken, I'll try and figure out why if I have time. |
Member
Author
Let't merge #1935 first, then I will rebase my branch. |
Member
|
I think you need to rebase to make the formatting changes go away. And the OSX aarch64 failure is spurious. |
SteveLauC
force-pushed
the
io-safety-memfd-event-eventfd
branch
from
ab164dd to
511f84b
Compare
SteveLauC
force-pushed
the
io-safety-memfd-event-eventfd
branch
from
511f84b to
27d1844
Compare
Member
Author
Rebased. |
Contributor
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds I/O safety for moduels:
sys/memfdsys/eventsys/eventfdBYW, I called
rustfmton these 4 files, which introduces some noise, sorry about this.