Skip to content

Allow Android to use timerfd #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2021
Merged

Allow Android to use timerfd #1509

merged 1 commit into from
Sep 12, 2021

Conversation

rtzoeller
Copy link
Collaborator

This is a continuation of #1336 which also enables the timerfd tests.

running 3 tests
test sys::test_timerfd::test_timerfd_unset ... ok
test sys::test_timerfd::test_timerfd_oneshot ... ok
test sys::test_timerfd::test_timerfd_interval ... ok

@rtzoeller @zachoverflow
Allow Android to use timerfd
2a31ac1 
Co-authored-by: zachoverflow <[email protected]>
@rtzoeller
Copy link
Collaborator Author

@asomers I'm looking into the current status of the rest of the tests on Android (as requested on the original PR), but I likely won't be able to complete that investigation for a week or two due to limited availibility.

I'm running the tests in Termux (without root), and it is subject to a number of limitations by the OS which a more privileged process might not be. For example, I can't ls /! I'm trying to narrow down if the tests are failing because the core functionality is broken, or because the test needs to be updated to account for the lack of permissions, but this could take some time.

@asomers
Copy link
Member

asomers commented Sep 3, 2021

It looks good, @rtzoeller . Do you actually use Nix on Android?

asomers
asomers approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 12, 2021

Build succeeded:

@bors bors bot merged commit bf4f273 into nix-rust:master Sep 12, 2021
@rtzoeller rtzoeller mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtzoeller @asomers