Skip to content

Conversation

trueNAHO
Copy link
Member

Fixes: 5f154bf ("nixos-module: disable programs.command-not-found by default")

@r-vdp
Copy link
Collaborator

r-vdp commented Apr 30, 2025

This is simply not needed anymore now, right?
Could you rebase to fix the merge conflict?

Fixes: 5f154bf ("nixos-module: disable programs.command-not-found by default")
@trueNAHO trueNAHO force-pushed the tests-remove-default-option-declaration branch from aca00ae to 16d7a3a Compare May 5, 2025 13:10
@trueNAHO
Copy link
Member Author

trueNAHO commented May 5, 2025

This is simply not needed anymore now, right?

What exactly do you mean? The previously mentioned commit 5f154bf ("nixos-module: disable programs.command-not-found by default") declares

programs.command-not-found.enable = lib.mkDefault false;

globally, making the

programs.command-not-found.enable = false;

declaration in /tests.nix redundant. This PR removes this redundant declaration.

Could you rebase to fix the merge conflict?

Done in 16d7a3a. There were no merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants