Pull 2.3 Latest #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issues: MAGETWO-95809 Item row total display incorrect value in API response MAGETWO-95830 Cannot create credit memo if the used in the order cart rule is deleted MAGETWO-70379 UI components Date filter field has non-localized date format MAGETWO-91735 Customer's store credit is not given back after Authorize.net failed payment
# Conflicts: # app/code/Magento/Catalog/Model/Product/Attribute/Backend/TierPrice/SaveHandler.php # app/code/Magento/Catalog/Model/Product/Attribute/Backend/TierPrice/UpdateHandler.php
[TSG-CSL3] For 2.3 (pr13)
- merged latest code from mainline branch
- merged latest code from mainline branch
Accepted Public Pull Requests: - #19135: Calling getCurrentUrl on Store will wrongly add "___store" parameter #18941 (by @Nazar65) - #19302: fixed Notification page Select Visible items issue (by @shikhamis11) - magento-engcom/import-export-improvements#153: Added notes and tooltip to import behavior field in import form (by @federivo) - #18069: Add CatalogSearch no results handle (by @progreg) - #19080: [BUGFIX] Forward-port of #14861 for Magento 2.3 (by @kanduvisla) - #17806: 17754-Fixed validation while creating new product attributes in admin (by @saravananvelu) - #19839: Fixed minicart cancel button area overlapping issue (by @gelanivishal) - #19736: [Review] Integration tests for not allowed review submission (by @eduard13) - #19769: Minor typos corrected. (by @milindsingh) - #19762: Typo corrected Update bound-nodes.js (by @developerarun) - #19222: Cleaned up PriceCurrency class (by @dverkade) - #19537: Resolved bad parameter on function (by @jaimin-ktpl) - #19726: Typo "customet_id" to "customer_id" fixed. (by @milindsingh) - #19711: Check repository label for possible non-string value (by @poveu) - #19702: Small fix in classes (by @iskolesnyk) - #19634: Fixed - Lifetime update syntax error #13309 (by @ssp58bleuciel) - #19672: fix: simplify literal boolean checks (by @DanielRuf) - #19514: Fixed upgrade issue if manufacturer attribute not exist in the database (by @suneet64) - #19134: [Framework] New Link is not correctly shown as Current if contains default parts (by @eduard13) Fixed GitHub Issues: - #18941: Calling getCurrentUrl on Store will wrongly add "___store" parameter (reported by @LucaGallinari) has been fixed in #19135 by @Nazar65 in 2.3-develop branch Related commits: 1. 0e8cd9f 2. 300772d 3. b9a37ce 4. 1378074 5. 70d76c7 6. 2e5697d 7. b9f72f7 8. 22edbb9 9. 3c869e7 10. f1363cf - #19285: On Notification page Select All and Select Visible both works same (reported by @hellotaran) has been fixed in #19302 by @shikhamis11 in 2.3-develop branch Related commits: 1. 58514a0 2. a4b989b 3. c805752 4. 4599646 5. daf5fb9 6. c23a55c 7. 9de0884 8. ac1355e 9. 77670fa 10. fad31c6 11. d2e5d87 - #18038: Add a custom layout handle when there are no search results (reported by @qsolutions-pl) has been fixed in #18069 by @progreg in 2.3-develop branch Related commits: 1. 23666ac 2. 158a0fd 3. d2c2c00 4. ac8d426 5. 258703c 6. ca8b15b 7. c1cbd00 - #14861: M2.2.3 : Unexpected behaviour when programmatically assigning products to a category (reported by @kanduvisla) has been fixed in #19080 by @kanduvisla in 2.3-develop branch Related commits: 1. 3905580 2. c2100db 3. d904697 4. 9b919f9 5. 9cb7a89 - #17754: Misleading error in Add Product Attribute screen (reported by @milossh) has been fixed in #17806 by @saravananvelu in 2.3-develop branch Related commits: 1. 90b1c76 2. 22c185e - #19836: Minicart cancel button area overlapping to cart subtotal label (reported by @cedarvinda) has been fixed in #19839 by @gelanivishal in 2.3-develop branch Related commits: 1. fca6649 2. d4ebf75 - #17442: Order getCreatedAtFormatted has bad params (reported by @patoch14) has been fixed in #19537 by @jaimin-ktpl in 2.3-develop branch Related commits: 1. 4a1d103 - #19721: Typo in SalesRule/Model/ResourceModel/Coupon/Usage.php (reported by @Delwin444) has been fixed in #19726 by @milindsingh in 2.3-develop branch Related commits: 1. a2bac04 - #13309: Lifetime update syntax error (reported by @navalnichnik) has been fixed in #19634 by @ssp58bleuciel in 2.3-develop branch Related commits: 1. 146f74a 2. 70056f5 - #19099: New Link is not correctly shown as Current if contains default parts (reported by @eduard13) has been fixed in #19134 by @eduard13 in 2.3-develop branch Related commits: 1. 29640f1 2. fea9aaf 3. 508832b 4. 769e46d 5. 4241175 6. 3ee9190 7. 2f8314c 8. 64daebd 9. a912d27
- merged latest code from mainline branch
Fixed issues: MAGETWO-95812 Required RMA Attributes are not validated while Customer submits a return MAGETWO-96420 [2.3.x] [Magento Cloud] Customer receives newsletter unsubscription email after registering for new account MAGETWO-96434 [2.3.x] Autoscroll is missed on JS error on Storefront PDP [mobile] MAGETWO-96408 [2.3.x] [Magento Cloud] Error when saving Bundle product with a Scheduled Update
- merged latest code from mainline branch
Accepted Public Pull Requests: - #20050: Add missing throws to PHPDoc (by @pmclain) - #20046: Added constants to unit codes to make it easier to reuse it if necessary (by @tiagosampaio) - #20022: [Fixed Radio alignment issue on Cart page #20021] (by @hitesh-wagento) - #19792: Fixed 19791: Logo vertical misalignment. (by @suryakant-krish) - #20005: Minor Typo fix in AbstractFilter.php (by @ajeetsinghcedcoss) - #19981: Fix issue 19887 creating new shipment: getting all trackers. (by @Nazar65) - #19978: Set correct email message encoding (by @4lexvav) - #19941: issue resolved:Undefined Variable $itemsOrderItemId (by @GovindaSharma) - #19799: Fix issue 19796 - Sales Order invoice Update Qty's Button is misaligned (by @speedy008) - #19914: Move website_name column into columnSet (by @bradleyfrye) - #19926: fixed issue #19925 Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout (by @cedarvinda) - #19929: Refactoring in Magento_SalesRule (by @agorbulin) - #19900: Fix negative credit memo #19899 (by @wojtekn) - #19752: Fixed Typo error avaialble -> available (by @gulshanchitranshcedcoss) - #19715: [TASK] Updated the implements for the Magento_Cms Adminhtml Controllers (by @lewisvoncken) - #19620: Fix issue causing attribute not loading when using getList (by @MiliTree) - #19467: Use semantic theme color variables, including global primary/secondary colors (by @Brengineer) - #19930: Refactoring magento sales sequence (by @agorbulin) - #19646: Area Frontend: Fixed checkbox alignment account information page. (by @suryakant-krish) Fixed GitHub Issues: - #20037: CategoryLinkReposity does not list all possible exceptions (reported by @troendheim) has been fixed in #20050 by @pmclain in 2.3-develop branch Related commits: 1. d08ce91 2. a1d3299 - #20021: Radio alignment issue on Cart page (reported by @hitesh-wagento) has been fixed in #20022 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 6089f27 - #19791: Logo vertical misalignment. (reported by @suryakant-krish) has been fixed in #19792 by @suryakant-krish in 2.3-develop branch Related commits: 1. 485b89f 2. 3a56397 3. 8e59e4b - #19887: creating new shipment: gettting all trackers. after this commit 2307e16 (reported by @aldf) has been fixed in #19981 by @Nazar65 in 2.3-develop branch Related commits: 1. 8048516 2. 9cf1e3e - #19977: E-Mail subject not showing utf-8 characters (reported by @4lexvav) has been fixed in #19978 by @4lexvav in 2.3-develop branch Related commits: 1. bccc949 - #19940: Exception undefined variable itemsOrderItemId while creating shipment through MSI (reported by @mohammadzakir) has been fixed in #19941 by @GovindaSharma in 2.3-develop branch Related commits: 1. b54ab2d - #19796: Sales Order invoice Update Qty's Button is misaligned (reported by @speedy008) has been fixed in #19799 by @speedy008 in 2.3-develop branch Related commits: 1. e30a080 2. 8a3fa61 - #19899: Credit memo for $0 order without refunded shipping produces negative credit memo (reported by @wojtekn) has been fixed in #19900 by @wojtekn in 2.3-develop branch Related commits: 1. e840e41 2. 4a77f29 3. 5b4fdca - #17759: M2.2.5 : CustomerRepository::getList() does not load custom attribute if the name is "company" (reported by @kanduvisla) has been fixed in #19620 by @MiliTree in 2.3-develop branch Related commits: 1. d600179 2. b99af38 3. e29c5dd - #19645: Area Frontend: Account information page checkbox alignment issue. (reported by @suryakant-krish) has been fixed in #19646 by @suryakant-krish in 2.3-develop branch Related commits: 1. 0811a71
…ing cart rules condition tab. #20042
…earch label icon alignment issue #19643
…Async Emails issues, Fix Multiple Email issues #18471
Accepted Public Pull Requests: - #20042: #12549: Payment method option is not showing under shopping cart rules condition tab. (by @p-bystritsky) - #19803: Fixed 19800 Contact us : design improvement (by @suryakant-krish) - #19643: Fixed issue 19642- Catalog product action multi select search label icon alignment issue (by @abrarpathan19) - #19644: correct devdocs url from http to https (by @ravi-chandra3197) - #19665: Configure missing group for core payment methods (by @wojtekn) - #18471: [2.3] Alternative fix for Multi Store Emails issue, Fix Async Emails issues, Fix Multiple Email issues (by @gwharton) - #18407: added config for newsletter in frontend (by @torhoehn) Fixed GitHub Issues: - #12549: Payment method option is not showing under shopping cart rules condition tab (reported by @AbdurBhadarka) has been fixed in #20042 by @p-bystritsky in 2.3-develop branch Related commits: 1. 76ca463 - #19800: Contact us : design improvement (reported by @suryakant-krish) has been fixed in #19803 by @suryakant-krish in 2.3-develop branch Related commits: 1. 10e7927 2. b618757 3. c8fa36f 4. abfa040 5. 2e08f60 6. 6e47e58 7. 9bf7ab7 - #19642: Catalog product action multi select search label icon alignment issue (reported by @abrarpathan19) has been fixed in #19643 by @abrarpathan19 in 2.3-develop branch Related commits: 1. f72c013 2. f49c569 - #19664: Payment methods from core source model are not grouped properly (reported by @wojtekn) has been fixed in #19665 by @wojtekn in 2.3-develop branch Related commits: 1. 614a7e4 2. 9566898 - #7739: "From Header set twice" when sending an email (reported by @RishabhRkRai) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #11740: Sending emails from Admin in Multi-Store Environment defaults to Primary Store (reported by @lee586) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #14236: Sending multiple emails using the TransportBuilder class causes an Zend_Mail exception (reported by @david-kominek) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #14945: Store Email Addresses are not used anymore (reported by @chequille) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #14952: Confirmation emails have no FROM or FROM email address 2.2.4 (reported by @tstamplis) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #16165: Sales Emails Async Sending issue (reported by @mihaifaget) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #16203: New order notification is not sent to the admin (reported by @bnymn) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #16355: Magento 2.2.4 not sending from sales sender (reported by @versdivers) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #16509: Magento 2.2.4 Multishipping Order Confirmation Emails sent only for the first order (reported by @arjuninfo) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #17781: Magento 2.2.5 Order Email Confirmation is not working (reported by @nilesh111091) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d - #18470: Store emails have correct from address but do not have a from name (reported by @gwharton) has been fixed in #18471 by @gwharton in 2.3-develop branch Related commits: 1. ad50297 2. e16ff74 3. 621d2cf 4. b6f9e48 5. 0dc8578 6. 122019c 7. 193c6c2 8. bd0aa57 9. 523b046 10. 424929f 11. c32ca7a 12. e39ce7a 13. 99621b3 14. f171c9d
[borg] MC-5570: Different Order Status of two created credit memo orders
niravkrish
pushed a commit
that referenced
this pull request
Jul 17, 2019
Regression Automation Team Sprint #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)