Skip to content

moved psutil from test dep to core dep #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

moved psutil from test dep to core dep #817

wants to merge 2 commits into from

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Apr 29, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Adds psutil as core dependency instead of just test. When resources are audited it imports the pydra.utils.profiler module, which has psutil as a dep.

Fixes #760

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (058d793) to head (42dbf0f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   88.76%   88.73%   -0.03%     
==========================================
  Files          84       84              
  Lines       17890    17897       +7     
  Branches     3483     3484       +1     
==========================================
+ Hits        15880    15881       +1     
- Misses       1640     1648       +8     
+ Partials      370      368       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose requested a review from djarecka April 30, 2025 00:36
@effigies
Copy link
Contributor

effigies commented May 5, 2025

I think we should endeavor to keep dependencies light, and core dependencies should be those necessary to access core functionality.

If audits are core functionality, then fine, but otherwise we could create an audit extra and documentation that indicates that users wishing to use that functionality should install that extra.

@tclose
Copy link
Contributor Author

tclose commented May 5, 2025

I'm easy either way. An 'audit' extra sounds like a reasonable idea, we just need to make sure that audit isn't imported unless it is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psutil dependency missing for Audit features
2 participants