Interfaces for fnirtfileutils and convertwarp (FSL) #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
changed the title
|
|
||
| if self.inputs.write_jacobian: | ||
| if not isdefined(self.inputs.out_jacobian): | ||
| self.inputs.out_jacobian = self._gen_fname(self.inputs.in_file, |
There was a problem hiding this comment.
Ok, but how to deal with files which name should be automatically generated but only if there's a boolean trait set? (I ask this because I honestly don't know how to do it, sorry for my ignorance).
There was a problem hiding this comment.
Ok, I think I got a solution :)
|
@juhuntenburg could you have a look at this? thanks! |
| 'coordinates in the next space.')) | ||
|
|
||
| out_abswarp = traits.Bool(argstr='--absout', xor=['out_relwarp'], | ||
| desc=('If set it indicates that the warps in --out should be relative, i.e. ' |
There was a problem hiding this comment.
in line 1629 it should say 'absolute' not 'relative'
|
convertwarp generally looks great, just a few things:
|
Enh/add interface fsl warp utils
Fixed some typos. Conflicts: CHANGES
|
With the updates from @juhuntenburg this can be merged. Thanks. |
oesteban
added a commit
that referenced
this pull request
Jul 28, 2014
Interfaces for fnirtfileutils and convertwarp (FSL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New interface to this two simple utilities to manage displacement fields and coefficients fields.