FUGUE interface refactoring #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUGUE interface was adding wrong parameter in forward warping mode. Added the missing doctest of the interface.
|
In reality, tests are passing. |
Deeply reviewed the interface to use the new name_template system, along with the correction of several issues. Also includes changes of another PR, so close nipy#856.
oesteban
changed the title
The workflow was using an input with its name changed.
Also replaced the name_source dynamic setting with str instead of lists, as it seems to produce errors when executing as MapNode of workflows.
|
Are you still experiencing problems with mapnode or is it ready to merge? |
|
I think this is OK, but let me double-check. I'm currently using this PR (rather intensively) and tomorrow I will check if all my workflows finished alright. |
Conflicts: CHANGES
|
This is working OK |
chrisgorgo
added a commit
that referenced
this pull request
Jul 29, 2014
FUGUE interface refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edited)
Deep revision of the interface. Including the following changes: