Skip to content

fugue broken by the refactor #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpinsard opened this issue Oct 24, 2014 · 7 comments · Fixed by #1110
Closed

fugue broken by the refactor #977

bpinsard opened this issue Oct 24, 2014 · 7 comments · Fixed by #1110
Assignees
Labels

Comments

@bpinsard
Copy link
Contributor

No _list_outputs is implemented in FUGUE interface, so no outputs is set by default.
this seems to be broken by this PR: #857
it seems that no tests are checking for outputs to be listed if file created.

@satra
Copy link
Member

satra commented Oct 24, 2014

@bpinsard - _list_outputs in no longer strictly necessary if name_source is implemented correctly.

at the top of our priority list is to start adding regression and interface tests. at least basic ones. so if you can post one with public data that would be great.

@bpinsard
Copy link
Contributor Author

is name_source the standard for fsl interfaces ?? or in general?
sorry, I have to catch up with the latest design choice in nipype.

@satra
Copy link
Member

satra commented Oct 24, 2014

for newer interfaces name_source is the standard where applicable - we are trying to push as much into specs and base classes where possible. and whenever we get a chance we update older interfaces to this. it would be a good project for a sprint.

@satra
Copy link
Member

satra commented Oct 24, 2014

btw, if you have time to go through your outstanding pull-requests we are happy to put the time into reviewing them over the next week or two.

@oesteban
Copy link
Contributor

Well, there is this old issue #573, that we could use to get rid of _list_outputs in mostly all situations (in a very convenient and transparent way).

Should we close this one?

@bpinsard
Copy link
Contributor Author

#978

@oesteban
Copy link
Contributor

Maybe @bpinsard or myself have a different nipype version... but in my settings #978 breaks FUGUE interface. Without it, FUGUE works for me (using the name_source feature).

oesteban added a commit to oesteban/nipype that referenced this issue May 25, 2015
satra added a commit that referenced this issue Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants