Skip to content

MAINT: Add dev install option, update CONTRIBUTING #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2018
Merged

MAINT: Add dev install option, update CONTRIBUTING #2477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc499b8
MAINT: Add dev install option, update CONTRIBUTING
effigies Mar 1, 2018
c1fd509
FIX: Work around install weirdness
effigies Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ Make sure to [keep your fork up to date][link_updateupstreamwiki] with the maste
If you're adding a new tool from an existing neuroimaging toolkit (e.g., 3dDeconvolve from AFNI), check out the [guide for adding new interfaces to Nipype][link_new_interfaces].

To confirm that your changes worked as intended, [clone your fork][link_cloning] to create a local directory.
In this local directory, run `python setup.py develop`.
This will add your version of nipype to your local python environment.
In this local directory, run `pip install -e .[dev]`.
This will add your version of nipype to your local python environment and
install dependencies needed for development.

Then, in this local nipype directory, run `make check-before-commit`. If you get no errors, you're ready to submit your changes!

Expand Down
10 changes: 9 additions & 1 deletion nipype/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,15 @@ def get_nipype_gitversion():
# 'mesh': ['mayavi'] # Enable when it works
}


def _list_union(iterable):
return list(set(sum(iterable, [])))


# Enable a handle to install all extra dependencies at once
EXTRA_REQUIRES['all'] = [val for _, val in list(EXTRA_REQUIRES.items())]
EXTRA_REQUIRES['all'] = _list_union(EXTRA_REQUIRES.values())
# dev = doc + tests + specs
EXTRA_REQUIRES['dev'] = _list_union(val for key, val in EXTRA_REQUIRES.items()
if key in ('doc', 'tests', 'specs'))

STATUS = 'stable'