Skip to content

ENH: Add Quickshear #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2017
Merged

ENH: Add Quickshear #2047

merged 2 commits into from
May 26, 2017

Conversation

effigies
Copy link
Member

Adds Quickshear defacing algorithm.

@codecov-io
Copy link

codecov-io commented May 24, 2017

Codecov Report

Merging #2047 into master will increase coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
+ Coverage   72.17%   72.18%   +0.01%     
==========================================
  Files        1134     1136       +2     
  Lines       57096    57126      +30     
  Branches     8179     8183       +4     
==========================================
+ Hits        41208    41238      +30     
+ Misses      14602    14601       -1     
- Partials     1286     1287       +1
Flag Coverage Δ
#smoketests 72.18% <93.33%> (+0.01%) ⬆️
#unittests 69.79% <93.33%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/quickshear.py 100% <100%> (ø)
nipype/interfaces/tests/test_auto_Quickshear.py 85.71% <85.71%> (ø)
nipype/interfaces/base.py 83.96% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4543dc...fbedb0f. Read the comment docs.

@satra
Copy link
Member

satra commented May 24, 2017

auto test?

@effigies
Copy link
Member Author

Gah. I really thought I was going to get this one in one commit.

@satra
Copy link
Member

satra commented May 24, 2017

perhaps this will incentive to consider what role the auto tests play and how we can address that role otherwise. actually it's the make specs check for metadata that i am generally most interested in.

@satra satra merged commit 88abb23 into nipy:master May 26, 2017
@effigies effigies deleted the enh/quickshear branch August 22, 2017 01:32
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants