Skip to content

[DOC] add documentation & doc tests to fsl preprocess #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 67 commits into from

Conversation

neuroumbrage
Copy link
Contributor

Adding working doc tests and updated the documentation links:

  • BET
  • FAST
  • McFLIRT
  • SUSAN (doc links only)

@codecov-io
Copy link

codecov-io commented Feb 25, 2017

Codecov Report

Merging #1851 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #1851     +/-   ##
========================================
- Coverage    73.1%     73%   -0.1%     
========================================
  Files        1064    1059      -5     
  Lines       53328   53258     -70     
========================================
- Hits        38985   38883    -102     
- Misses      14343   14375     +32
Flag Coverage Δ
#unittests 73% <100%> (-0.1%)
Impacted Files Coverage Δ
nipype/algorithms/tests/test_auto_ComputeDVARS.py 92.85% <ø> (ø)
...lgorithms/tests/test_auto_FramewiseDisplacement.py 92.85% <ø> (ø)
...nterfaces/freesurfer/tests/test_auto_BBRegister.py 92.85% <ø> (ø)
nipype/pipeline/engine/tests/test_engine.py 94.23% <100%> (ø)
nipype/utils/tests/test_filemanip.py 80.54% <100%> (-12.67%)
nipype/interfaces/fsl/preprocess.py 77.51% <100%> (ø)
nipype/interfaces/fsl/tests/test_maths.py 100% <100%> (ø)
nipype/init.py 65.62% <0%> (-3.13%)
nipype/utils/tests/test_cmd.py 95.65% <0%> (-2.9%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52524e...9c3f5ee. Read the comment docs.

@effigies effigies mentioned this pull request Mar 6, 2017
satra and others added 17 commits March 6, 2017 20:33
fixing tests and install errors
Estimated transform files in spm realign output directory for 4D files
When strings are formatted in unicode, then the format
of the AntsJointFusion -g, -t flags is not the same
as the python string representations of lists.  These
flags need to be unpacked one-by-one and a new string
representation needs to be provided on the command line.
The doctest of antsJointFusion was failing since nipy#1862, these changes
hopefully fix this problem without breaking the correct functionality
of the interface.

Also corrected what I suspect is an error: -l was replaced by -t for
the segmentations.
[FIX] Doctest of antsJointFusion failing
@neuroumbrage
Copy link
Contributor Author

I rebased and ran make specs. A lot of the test files are no longer changed, however, auto tests for BBRegister, ApplyXFM, and ApplyXfm are all changed. Should I commit my updated version with the changed auto tests or without?

@effigies
Copy link
Member

Only update auto tests where they reflect changes you've made in the interfaces they're testing. I don't think you've changed any, so I'd leave all of them out.

# Conflicts:
#	nipype/algorithms/tests/test_auto_NonSteadyStateDetector.py
@satra
Copy link
Member

satra commented Mar 14, 2017

@neuroumbrage - would you mind closing this PR and creating a new PR. because of some github mechanics this pull-request shows a lot of changes that are already in master.

http://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants