Skip to content

Estimated transform files in spm realign output directory for 4D files #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2017
Merged

Estimated transform files in spm realign output directory for 4D files #1874

merged 2 commits into from
Mar 11, 2017

Conversation

himito
Copy link
Contributor

@himito himito commented Mar 9, 2017

Hello,

I'm working with 4D files and SPM and I didn't find a way to copy the estimated transform files generated by spm realign into the output folder of my workflow.

Also, I found that when these header files are not in the working directory of another node (eg, normalization), then the results of Nipype are different from those when the same workflow is executed in SPM Matlab.

I hope these modifications are useful.

Cheers,
Jaime

@himito
Copy link
Contributor Author

himito commented Mar 9, 2017

Hi @satra,

here the new solution :)

thank you for your time and help.

Jaime

@effigies
Copy link
Member

Want to update the test?

https://github.com/nipy/nipype/blob/master/nipype/utils/tests/test_filemanip.py#L323-L324

@@ -30,7 +30,7 @@


related_filetype_sets = [
('.hdr', '.img', '.mat'),
('.hdr', '.img', '.mat', '.nii'),
Copy link
Member

@satra satra Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps add an additional row here:

('.nii', '.mat'),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and remove the .nii from the previous set.

@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

Merging #1874 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   73.11%   73.11%   -0.01%     
==========================================
  Files        1061     1061              
  Lines       53367    53367              
==========================================
- Hits        39019    39017       -2     
- Misses      14348    14350       +2
Flag Coverage Δ
#unittests 73.11% <ø> (-0.01%)
Impacted Files Coverage Δ
nipype/utils/filemanip.py 87.17% <ø> (ø)
nipype/utils/tests/test_filemanip.py 93.21% <ø> (ø)
nipype/interfaces/base.py 84.84% <0%> (-0.19%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81d993...f41abd9. Read the comment docs.

@himito
Copy link
Contributor Author

himito commented Mar 10, 2017

voilà @satra @effigies :)
Thank you for your help :)
Jaime

@satra satra merged commit 10b9675 into nipy:master Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants