Skip to content

Unset default init for BBRegister in FS 6+ #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

effigies
Copy link
Member

Instead of replicating FS default of --init-coreg, set init as non-mandatory.

Follow-up to #1811.

@effigies
Copy link
Member Author

Following discussion with @chrisfilo, default interface is for FreeSurfer 6, so spec tests are set to non-mandatory.

@satra
Copy link
Member

satra commented Feb 14, 2017

@effigies - can't we support both with something along the lines of what we do in FSL:

class FILMGLSInputSpec507(FILMGLSInputSpec505):

and depending on local version the appropriate inputspec gets used?

@satra
Copy link
Member

satra commented Feb 14, 2017

this is out current measure before we move to versioned interfaces. also each input parameter can be version controlled with min_ver and max_ver (see: http://nipype.readthedocs.io/en/latest/devel/interface_specs.html#common)

@codecov-io
Copy link

Codecov Report

Merging #1817 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1817   +/-   ##
=======================================
  Coverage   69.82%   69.82%           
=======================================
  Files        1047     1047           
  Lines       52137    52137           
  Branches     7670     7670           
=======================================
  Hits        36405    36405           
  Misses      14150    14150           
  Partials     1582     1582
Flag Coverage Δ
#unittests 69.82% <ø> (ø)
Impacted Files Coverage Δ
...nterfaces/freesurfer/tests/test_auto_BBRegister.py 84.61% <ø> (ø)
nipype/interfaces/freesurfer/preprocess.py 64.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b304510...3a90ffb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants