-
Notifications
You must be signed in to change notification settings - Fork 536
Do not open nifti files with mmap if numpy < 1.12.0 #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
7cbe9df
Do not open nifti files with mmap if numpy < 1.12.0
oesteban 0db15b5
fix leftover typo
oesteban b67868f
use anaconda in travis cc #1788
oesteban b5899cd
simplify conda installation
oesteban 332d46d
remove adding conda-forge channel
oesteban 85ca6e5
readd conda update
oesteban c411e23
remove requirement version in nibabel
oesteban 0d5d6dd
revise conda installation
oesteban 70a7cb2
fix travis file
oesteban 452a284
add icu to conda (#1798), append conda-forge instead of prepend
oesteban 4291ffc
install boto3 in python 3
oesteban bdf62ab
Merge remote-tracking branch 'upstream/master' into fix/1795
oesteban a34c0fd
fix travis.xml
oesteban 11fd619
fix travis (second round)
oesteban 2ec16f8
fix conda-forge channel, split anaconda download
oesteban 5b46772
remove breaklines
oesteban 1308921
do not try to install conda after a travis_retry
oesteban 2abe8f5
do not use travis python
oesteban 25e65b9
roll back to miniconda, use some hints from https://conda.io/docs/tra…
oesteban 5d60cef
fix error in travis.yml
oesteban 1c956b0
remove if switch
oesteban 13b3cc6
fix miniconda link
oesteban d37d440
Merge remote-tracking branch 'upstream/master' into fix/1795
oesteban ebaaebd
Merge branch 'fix/1795' of github.com:oesteban/nipype into fix/1795
oesteban 3d1e644
fix command to update conda to a certain version
oesteban f3ebcc5
reenable version pinning for nibabel in requirements.txt
oesteban 3820f9f
replace all nibabel imports and the nibabel.load to have the NUMPY_MMAP
oesteban 671fc03
add NUMPY_MMAP import
oesteban 05d74ec
more NUMPY_MMAP fixes
oesteban 875ed0b
the last nibabel.load without NUMPY_MMAP
oesteban 20e10f9
fix import NUMPY_MMAP location in examples
oesteban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oesteban - sorry if this was somehow my fault - but why did we switch to anaconda? miniconda gives us everything we need right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satra I was just checking if switching to anaconda made any difference as regards the segmentation fault, but I'm arriving to the conclusion that miniconda is much better for travis. So there's no point on switching.