Skip to content

Fixes for tCompCor #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2016
Merged

Fixes for tCompCor #1745

merged 2 commits into from
Dec 11, 2016

Conversation

chrisgorgo
Copy link
Member

  • input mask is not being ignored anymore (fixes tCompCor ignores the input mask #1744)
  • use np.percentile instead of implementing it by hand
  • output the estimated high variance mask (useful for debugging)

@codecov-io
Copy link

Current coverage is 71.11% (diff: 68.42%)

Merging #1745 into master will decrease coverage by <.01%

@@             master      #1745   diff @@
==========================================
  Files          1028       1028          
  Lines         50608      50616     +8   
  Methods           0          0          
  Messages          0          0          
  Branches       7331       7333     +2   
==========================================
+ Hits          35992      35994     +2   
+ Misses        13491      13488     -3   
- Partials       1125       1134     +9   

Powered by Codecov. Last update 8ff1851...214d316

@satra satra merged commit 7e6c3c9 into nipy:master Dec 11, 2016
@djarecka
Copy link
Collaborator

did you change nipype/algorithms/tests/test_auto_TCompCor_test.py running python tools/checkspecs.py? I'm getting a different file when running python tools/checkspecs.py or make specs:
djarecka@ac65ea4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tCompCor ignores the input mask
4 participants