Skip to content

Update N4BiasFieldCorrection inputs for compatibility #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 6, 2015
Merged

Update N4BiasFieldCorrection inputs for compatibility #1096

merged 10 commits into from
Jul 6, 2015

Conversation

blakedewey
Copy link
Contributor

Update N4BiasFieldCorrection to use short tag for compatibility with new releases as long tag has changed.

Update to current master
Using short tag will allow use of newest ANTs releases as well as provide backward compatibility as only the long tag changed. Also removed conflicting `requires` tags.
@satra
Copy link
Member

satra commented Apr 29, 2015

@blakedewey - could you also please run make check-before-commit (see CONTRIBUTING.md) and then commit the changes and push. the auto tests are failing because you updated the interface.

@satra
Copy link
Member

satra commented Jul 1, 2015

@blakedewey - could you please merge with current master so that tests pass?

This rolls back to commit 127f2fc.
Merge to update with master from nipy
@blakedewey
Copy link
Contributor Author

I did as much as I could for the time being. My test setup for commits is all messed up from some playing around that I did. I will try to recreate it and upload the test/CHANGES file changes.

Update to current master
…nce threshold is not specified in N4BiasField Correction. Tests updated to match (with updates for image_dimension changes).
@blakedewey
Copy link
Contributor Author

@satra This should be ready to go. Sorry for the delay.

satra added a commit that referenced this pull request Jul 6, 2015
Update N4BiasFieldCorrection inputs for compatibility
@satra satra merged commit e497543 into nipy:master Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants