RF: minc - delay import of h5py until needed. #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian systems h5py comes with MPI enabled build.
I guess on some misconfigured systems, like my laptop, it might take awhile to import.
And since h5py here is imported upon import of `nibabel`, it makes
it long(er) to import it. Here is timing on my laptop before the change:
$> time python -c 'import nibabel'
python -c 'import nibabel' 0.20s user 0.08s system 5% cpu 5.356 total
and here is after the change:
$> time python -c 'import nibabel'
python -c 'import nibabel' 0.13s user 0.02s system 100% cpu 0.150 total
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 89.55% 89.38% -0.17%
==========================================
Files 96 96
Lines 12378 12378
Branches 2184 2184
==========================================
- Hits 11085 11064 -21
- Misses 944 966 +22
+ Partials 349 348 -1
Continue to review full report at Codecov.
|
|
Can't see any reason to delay it. I'll also cherry-pick into |
|
THANK YOU @effigies ! |
|
I am a bit confused by coverage report, ... but oh well -- it is not the first time this happens to me ;) |
|
Yeah, it can be a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian systems h5py comes with MPI enabled build.
I guess on some misconfigured systems, like my laptop, it might take awhile to import.
And since h5py here is imported upon import of
nibabel, it makesit long(er) to import it. Here is timing on my laptop before the change:
and here is after the change: