Skip to content

TEST: Refactor NetCDF tests to be more pytest friendly #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 5, 2020

No description provided.

@effigies effigies mentioned this pull request Feb 5, 2020
37 tasks
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #879 into pytest will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           pytest     #879      +/-   ##
==========================================
- Coverage   89.75%   89.51%   -0.24%     
==========================================
  Files          97       97              
  Lines       12403    12156     -247     
  Branches     2185     2185              
==========================================
- Hits        11132    10882     -250     
  Misses        927      927              
- Partials      344      347       +3
Impacted Files Coverage Δ
nibabel/dft.py 80.98% <0%> (ø) ⬆️
nibabel/freesurfer/io.py 94.22% <0%> (ø) ⬆️
nibabel/environment.py 95% <0%> (ø) ⬆️
nibabel/casting.py 86.14% <0%> (ø) ⬆️
nibabel/openers.py 94.89% <0%> (-0.16%) ⬇️
nibabel/nicom/dicomwrappers.py 90.35% <0%> (-0.56%) ⬇️
nibabel/nicom/csareader.py 87.4% <0%> (ø) ⬆️
nibabel/ecat.py 87.7% <0%> (-0.37%) ⬇️
nibabel/volumeutils.py 82.84% <0%> (-1.3%) ⬇️
nibabel/cifti2/cifti2_axes.py 98.26% <0%> (-0.09%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4b703...e763c89. Read the comment docs.

@effigies effigies force-pushed the test/refactor_netcdf_tests branch from a4cfbcf to 7dfef14 Compare February 5, 2020 14:53
@effigies effigies force-pushed the test/refactor_netcdf_tests branch from 7dfef14 to e763c89 Compare February 5, 2020 14:54
@effigies effigies merged commit fb2a828 into nipy:pytest Feb 5, 2020
@effigies effigies deleted the test/refactor_netcdf_tests branch February 5, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant