Skip to content

DOC: Discuss slicer interface #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2019
Merged

DOC: Discuss slicer interface #846

merged 1 commit into from
Dec 2, 2019

Conversation

effigies
Copy link
Member

We never documented the slicer interface outside the API docs, which is less prominent than the feature deserves, given its usefulness, IMO.

Comments appreciated.

Follow-up to #550.

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #846 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   90.09%   89.78%   -0.32%     
==========================================
  Files          98       98              
  Lines       12450    12450              
  Branches     2188     2188              
==========================================
- Hits        11217    11178      -39     
- Misses        883      918      +35     
- Partials      350      354       +4
Impacted Files Coverage Δ
nibabel/pydicom_compat.py 63.63% <0%> (-36.37%) ⬇️
nibabel/nicom/dicomwrappers.py 85.16% <0%> (-5.75%) ⬇️
nibabel/__init__.py 89.28% <0%> (-3.58%) ⬇️
nibabel/viewers.py 95.49% <0%> (-0.65%) ⬇️
nibabel/nifti1.py 91.21% <0%> (-0.31%) ⬇️
nibabel/volumeutils.py 92.45% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7f0cc...7d1badf. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Dec 2, 2019

Doctest passing. Please open a PR if you have suggestions for improvements.

@effigies effigies merged commit 7527247 into nipy:master Dec 2, 2019
@effigies effigies deleted the doc/slicer branch December 11, 2019 14:42
@effigies effigies added this to the 3.0.0 milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant