Skip to content

REL: 3.0.0rc1 #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 16, 2019
Merged

REL: 3.0.0rc1 #829

merged 6 commits into from
Nov 16, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 24, 2019

Preparation for 3.0.0 Release Candidate 1, targeting Monday, October 28.

This will mark a feature freeze for Nibabel 3.0, so there will be a strong inclination to delay for features that are being actively completed. Bug fixes will be accepted between the release candidate and the final release.

Please comment to flag any other issues that should be addressed. There is the 3.0.0 RC1 milestone but a few of them are pretty stale, and I don't have the bandwidth to push them, so they're very likely to get dropped in this cycle.

Pre-release checklist

  • Review the open list of nibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
  • Review and update the release notes. Review and update the Changelog file.
  • Look at doc/source/index.rst and add any authors not yet acknowledged.
  • Use the opportunity to update the .mailmap file if there are any duplicate authors listed from git shortlog -nse.
  • Check the copyright year in doc/source/conf.py
  • Refresh the README.rst text from the LONG_DESCRIPTION in info.py by running make refresh-readme.
  • Check the dependencies listed in setup.cfg (e.g., install_requires, options.extras_require) and in doc/source/installation.rst and in requirements.txt and .travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
  • Make sure all tests pass (from the nibabel root directory): nosetests --with-doctest nibabel
  • Edit nibabel/info.py to set _version_extra to ''; commit

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@effigies
Copy link
Member Author

@yarikoptic I needed to patch versioneer again (cf. #816) to deal with the branch name here. Do you think we should fully fork versioneer in a nipy/versioneer repository?

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #829 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          98       98           
  Lines       12450    12450           
  Branches     2188     2188           
=======================================
  Hits        11217    11217           
  Misses        883      883           
  Partials      350      350
Impacted Files Coverage Δ
nibabel/_version.py 100% <ø> (ø) ⬆️
nibabel/info.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b773576...cfa1cb4. Read the comment docs.

@effigies effigies force-pushed the rel/3.0.0rc1 branch 2 times, most recently from 7323476 to 6586e06 Compare October 29, 2019 01:16
@effigies effigies merged commit 85f18e9 into master Nov 16, 2019
@effigies effigies deleted the rel/3.0.0rc1 branch November 18, 2019 15:12
@effigies
Copy link
Member Author

@djarecka @chrisgorgo I grabbed your Zenodo entries from Nipype, but bumped Chris' affiliation to Google. Please let me know if you'd like these changed before the final release.

@djarecka
Copy link
Collaborator

@effigies - thanks for adding. However, I've just realized that this is not my number (yes, it's the same as in nipype - it must have been copied from "Ziegler, Erik", I'll correct it today)
My number is: 0000-0001-8282-2988

@effigies
Copy link
Member Author

Yikes. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants