Skip to content

Q: any plans/possibility to avoid patching versioneer.py? #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yarikoptic opened this issue Sep 20, 2019 · 5 comments
Closed

Q: any plans/possibility to avoid patching versioneer.py? #816

yarikoptic opened this issue Sep 20, 2019 · 5 comments

Comments

@yarikoptic
Copy link
Member 

$> git grep 'CJM:' versioneer.py 
versioneer.py:    # CJM: Nibabel hack to ensure we can git-archive off-release versions and
versioneer.py:    # CJM: Nibabel fix to avoid hitting unguarded dictionary lookup, better explanation
versioneer.py:    # CJM: Nibabel hack to ensure we can git-archive off-release versions and

I wondered if you (@effigies) anyhow considered/discussed with versioneer.py to make it possible to have versioneer.py needed functionality without nibabel patching it?
@effigies
Copy link
Member

They haven't responded to issues or PRs in years at this point.

@effigies
Copy link
Member

That said, I'm open to forking, opening a PR, and using that fork unless the fixes we need are eventually included.

@yarikoptic
Copy link
Member Author

Ah, I didn't know that it is not active

@effigies
Copy link
Member

Maybe if we find that we need to hack on it again for this or another project, we could make a nipy fork to consolidate effort and get more eyes on it.

yarikoptic added a commit to dandi/dandi-cli that referenced this issue Sep 27, 2019
@yarikoptic
Initial skeleton inspired by "contemporary" nibabel
5868585 
Majority of the setuptools specification is within setup.cfg,
versioneer (patched, see nipy/nibabel#816
on related discussion) provides version "management", setup.py is minimalistic,
pyproject.toml provides build dependencies

Time will show how well it serves us ;)
@effigies effigies mentioned this issue Oct 24, 2019
Merged
11 tasks
jwodder pushed a commit to dandi/dandi-schema that referenced this issue May 20, 2021
@yarikoptic
Initial skeleton inspired by "contemporary" nibabel
b6b39c5 
Majority of the setuptools specification is within setup.cfg,
versioneer (patched, see nipy/nibabel#816
on related discussion) provides version "management", setup.py is minimalistic,
pyproject.toml provides build dependencies

Time will show how well it serves us ;)
@effigies
Copy link
Member

Dropped versioneer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarikoptic @effigies