Skip to content

REL: 2.5.1 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2019
Merged

REL: 2.5.1 #808

merged 6 commits into from
Sep 23, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 15, 2019

Preparation for 2.5.1 release, targeting Monday, September 23.

Getting started mostly as a heads up, but I also expect a busy weekend next week, so it'd be nice to have everything merged and tested by Friday morning (EDT).

Open issues/PRs that could go in quickly

Please add any other issues that should be addressed to the 2.5.1 milestone (or comment, if you don't have permissions), and if they come with a PR, all the better.

Pre-release checklist

  • Review the open list of nibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
  • Review and update the release notes. Review and update the Changelog file.
  • Look at doc/source/index.rst and add any authors not yet acknowledged.
  • Use the opportunity to update the .mailmap file if there are any duplicate authors listed from git shortlog -nse.
  • Check the copyright year in doc/source/conf.py
  • Refresh the README.rst text from the LONG_DESCRIPTION in info.py by running make refresh-readme.
  • Check the dependencies listed in setup.cfg (e.g., install_requires, options.extras_require) and in doc/source/installation.rst and in requirements.txt and .travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
  • Make sure all tests pass (from the nibabel root directory): nosetests --with-doctest nibabel
  • Edit nibabel/info.py to set _version_extra to ''; commit

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@effigies effigies added this to the 2.5.1 milestone Sep 15, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #808 into maint/2.5.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           maint/2.5.x    #808      +/-   ##
==============================================
+ Coverage        89.99%     90%   +<.01%     
==============================================
  Files               95      95              
  Lines            12049   12048       -1     
  Branches          2143    2142       -1     
==============================================
  Hits             10844   10844              
+ Misses             858     857       -1     
  Partials           347     347
Impacted Files Coverage Δ
nibabel/info.py 100% <100%> (ø) ⬆️
nibabel/gifti/gifti.py 95.23% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ff2de...1ab44e7. Read the comment docs.

@effigies effigies merged commit a616f7f into maint/2.5.x Sep 23, 2019
@effigies effigies deleted the rel/2.5.1 branch September 23, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants