FIX: Coerce data types on writing GIFTI DataArrays #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maint/2.5.x #806 +/- ##
===============================================
- Coverage 90% 89.98% -0.03%
===============================================
Files 95 95
Lines 12048 12046 -2
Branches 2142 2143 +1
===============================================
- Hits 10844 10839 -5
- Misses 857 859 +2
- Partials 347 348 +1
Continue to review full report at Codecov.
|
|
Anybody feeling up for a review? |
Includes a hack to keep the old data_tag API functional
effigies
force-pushed
the
fix/gifti_types
branch
from
9d24a5d to
2838c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with a test. I expect uniform failure.
cc @hyperbolicTom
Fixes #792.