ENH: deprecate Wrapper.get_affine - use affine property #796
Conversation
Codecov Report
@@ Coverage Diff @@
## maint/2.5.x #796 +/- ##
==============================================
- Coverage 90% 90% -0.01%
==============================================
Files 95 94 -1
Lines 12045 12044 -1
Branches 2142 2142
==============================================
- Hits 10841 10840 -1
Misses 857 857
Partials 347 347
Continue to review full report at Codecov.
|
…rting See PR in nibabel to RF for this: nipy/nibabel#796
|
Easiest is to rebase on the maintenance branch. We can still merge that branch into master pretty easily. Can move to a backport approach once that gets painful. |
maint/2.5.x ? |
|
ok, tests against master passed. rebased, force pushed and now will change the base in the PR to maint/2.5.x |
yarikoptic
force-pushed
the
rf-no_get_affine
branch
from
d9c6d9a to
29b7b63
Compare
|
Looks like CI got confused about the changing target branch. Bumped. |
|
Thanks, @yarikoptic. Would you mind updating the class docstring to note that On the whole, it looks like the class could use some conforming to the |
|
@yarikoptic If you care to update the docstring, this could go in the next release, which should be a week or so. |
|
Sorry @effigies for not reacting, thanks for pushing the tune up! |
|
The AppVeyor failures are fixed in #804, so the easiest fix is to merge that and merge or rebase |
|
please proceed any way you see best fit ;) |
To stay inline with the regular interfaces
effigies
force-pushed
the
rf-no_get_affine
branch
from
ce163cf to
0932c6d
Compare
|
@yarikoptic Good to merge? |
|
Sure, why not? ;-) |
To stay inline with the regular interfaces
If there are maintenance releases to happen with python2 support -- this should probably cherry picked there or I could rebase -- should it be maint/2.5.x?