Stop adding extraneous metadata padding #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the metadata field is already aligned to a 16-byte boundary then don't add a additional padding. This allows the user to create a 16-byte aligned extension padded with 0x20 that can be read by the Jim software (which doesn't like finding 0x00 in the metadata chunk).
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=========================================
- Coverage 94.46% 93.4% -1.06%
=========================================
Files 177 189 +12
Lines 24936 25820 +884
Branches 2659 2752 +93
=========================================
+ Hits 23556 24118 +562
- Misses 908 1205 +297
- Partials 472 497 +25
Continue to review full report at Codecov.
|
|
Good catch. Any chance of writing a test for this case? |
|
@effigies I've extended test_nifti1/test_extension_basics to cover this situation. Unfortunately coveralls is still showing that as a drop in coverage but both code paths are executed (unless I've missed something). |
|
The coverage checks can be a little weird at times. The main one I pay attention to is the diff. |
effigies
approved these changes
Feb 6, 2018
|
Looks good to me too - thanks for the spot ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the metadata field is already aligned to a 16-byte boundary then
don't add additional padding. This allows the user to create a
16-byte aligned extension padded with 0x20 that can be read by the Jim
software (which doesn't like finding 0x00 in the metadata chunk).