MRG: test fixes and doc updates for multiframe code #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
changed the title
|
@embaker - I found some small stuff that I hadn't spotted, that needed cleaning up. |
matthew-brett
force-pushed
the
more-multiframe-links
branch
from
e960206 to
92c93e0
Compare
More links to sections and diagrams on multi-frame / enhanced MR image IOP.
PEP8 fussy about exact number of blank lines.
Require DICOM for multiframe image shape tests.
Whitespace changes only.
matthew-brett
force-pushed
the
more-multiframe-links
branch
from
92c93e0 to
bf0b018
Compare
|
LGTM. Is there a reason that PRs are no longer built on the nipy Travis account? |
|
Hmm - good question about travis-ci and PRs - it seems it got turned off somehow - I turned it back on. |
|
@embaker - any comment here before I merge? |
|
I'll merge to make it easier to test other PRs - bit please do add any comments here, I'll address them with another PR. |
|
No comments. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to some new test failures at : https://travis-ci.org/matthew-brett/nibabel/builds/121846880
More links to sections and diagrams on multi-frame / enhanced MR image
IOP.
Follow-up to PR #439.