Skip to content

ENH: reading PAR headers from NIfTI extensions #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2015

Conversation

matthew-brett
Copy link
Member

A small function to fetch PARHeader object from PAR headers recorded in NIfTI
comment extensions.

A small function to fetch PARHeader object from PAR headers recorded in
NIfTI comment extensions.
@larsoner
Copy link
Contributor

larsoner commented Jul 4, 2015

Ready for review from your end? cc @mrjeffs in case you don't follow the repo, you'd probably be interested in this

@matthew-brett
Copy link
Member Author

Yes, ready for review...

@larsoner
Copy link
Contributor

larsoner commented Jul 5, 2015

LGTM -- looks reasonable, is reasonably tested, and tests pass. +1 for merge from me.

Extend API of `exts2pars` to allow passing list of extensions.
@matthew-brett
Copy link
Member Author

I added a little more flexibility - any more comments?

@larsoner
Copy link
Contributor

larsoner commented Jul 8, 2015

LGTM

matthew-brett added a commit that referenced this pull request Jul 9, 2015
MRG: reading PAR headers from NIfTI extensions

A small function to fetch PARHeader object from PAR headers recorded in NIfTI
comment extensions.
@matthew-brett matthew-brett merged commit 368c407 into nipy:master Jul 9, 2015
@matthew-brett matthew-brett deleted the read-par-exts branch July 9, 2015 14:33
grlee77 pushed a commit to grlee77/nibabel that referenced this pull request Mar 15, 2016
MRG: reading PAR headers from NIfTI extensions

A small function to fetch PARHeader object from PAR headers recorded in NIfTI
comment extensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants