MRG: some refactoring of PARREC API #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The file-loading API needs some thought, because I would also like to be able to pass in a parameter |
| @@ -82,9 +82,6 @@ | |||
| from copy import deepcopy | |||
| import re | |||
|
|
|||
| from .externals.six import string_types | |||
| from .py3k import asbytes | |||
|
|
|||
There was a problem hiding this comment.
FYI I already have these changes in my PR #263
|
Makes sense to have |
Test that truncated PAR/REC file raises error or warning according to `permit_truncated` flag.
Add `permit_truncated` to header attributes. Fix `copy` method to use value of `permit_truncated` when making a copy. Test.
Add methods with optional args `permit_truncated` and `scaling`: * from_file_map * from_filename * load
matthew-brett
force-pushed
the
parrec-fix-refactor
branch
from
04e953a to
e20a1cd
Compare
Add decorator to make keyword arguments keyword-only for Python 2.
Use and test keyword-onliness of permit_truncated, scaling argument to PARRECImage file loading methods.
|
I added the keyword-only stuff - I think it's ready now. |
|
Fancy solution, I like it. LGTM. |
matthew-brett
added a commit
that referenced
this pull request
Oct 24, 2014
MRG: some refactoring of PARREC API Add fake truncated file for testing, and test. Add permit_truncated as header attribute. Fix header copy to use permit_truncated. Add file loading API methods with PARREC-specific parameters. Make PARREC-specific parameters keyword-only.
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: some refactoring of PARREC API Add fake truncated file for testing, and test. Add permit_truncated as header attribute. Fix header copy to use permit_truncated. Add file loading API methods with PARREC-specific parameters. Make PARREC-specific parameters keyword-only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fake truncated file for testing, and test.
Add permit_truncated as header attribute.
Fix header copy to use permit_truncated.
Add file loading API methods with PARREC-specific parameters.