Siemens CSA header limit #270
Conversation
…r headers. Resolves nipy#212
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 67.51% 67.54% +0.02%
==========================================
Files 30 30
Lines 2423 2425 +2
==========================================
+ Hits 1636 1638 +2
Misses 787 787
Continue to review full report at Codecov.
|
| lgr.info('Filtering out {0} dicoms based on their filename'.format( | ||
| nfl_before-nfl_after)) | ||
| import nibabel.nicom.csareader | ||
| nibabel.nicom.csareader.MAX_CSA_ITEMS = 400 |
There was a problem hiding this comment.
Ok with me, but may be we should look into either changing it in nibabel itself?
if we are to patch it here, then we should make it conditional like
nibabel.nicom.csareader.MAX_CSA_ITEMS = max(nibabel.nicom.csareader.MAX_CSA_ITEMS, 400)so we do not bring it down if it is already set higher! but again -- better be changed etc in nibabel since what if they just drop/rename that variable? then our change would either be of no effect
|
Good point, this really belongs in |
Increase item limit to 400 to allow parsing larger headers. Resolves #212