-
Notifications
You must be signed in to change notification settings - Fork 43
Resample surfaces to any space/density using Connectome Workbench. #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I believe the failed docs check was because TemplateFlow S3 hasn't been updated. |
@feilong I think we can do this just by updating the parameterization of the existing workflow. I pushed my suggestion directly, but feel free to force-push back to yours. Here are the diffs:
@mgxd This needs your review, since you use this function in nibabies. |
@effigies Your suggestions make a lot of sense to me. The only reason I kept |
…void duplicate code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think this is in good shape. @mgxd would you mind having another look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy with these changes!
@feilong The docs are failing because |
@effigies I believe this is due to a TemplateFlow issue: templateflow/tpl-onavg#1 |
Adding
init_resample_surfaces_wb_wf
, which is similar toinit_resample_surfaces_wf
but not limited to fsLR spaces.It can resample surfaces to the specified space and density if the corresponding files exist in TemplateFlow.
For non-fsLR templates, it needs the
space-fsLR
files of the template, which connects the registered sphere (fsLR space) with the template (template space).For example, with
tpl-onavg_space-fsLR_hemi-L_den-10k_sphere.surf.gii
it can resample the subject's surfaces tospace-onavg_hemi-L_den-10k
.The code is mostly copied and modified from
init_resample_surfaces_wf
.