RF: Remove much of the hardcoded T1w fields in favor of anat
#433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
force-pushed
the
enh/nibabies-fit-apply
branch
2 times, most recently
from
19049f4 to
3dd026f
Compare
|
@effigies This should be ready for review. I've tried to limit any breaking changes, but regardless this will need to be included in a new minor release |
mgxd
force-pushed
the
enh/nibabies-fit-apply
branch
from
4013bfe to
0e1b7cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 66.37% 66.45% +0.08%
==========================================
Files 30 30
Lines 2079 2087 +8
Branches 249 250 +1
==========================================
+ Hits 1380 1387 +7
- Misses 698 699 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Jul 26, 2024
effigies
reviewed
Jul 26, 2024
effigies
reviewed
Jul 26, 2024
effigies
approved these changes
Jul 26, 2024
effigies
added a commit
to nipreps/fmriprep
that referenced
this pull request
Jul 26, 2024
mgxd
added a commit
that referenced
this pull request
Aug 1, 2024
0.16.0 (July 31, 2024) Start of the 0.16.x minor series. This release decouples much of the hardcoded T1w behavior in favor of T1w/T2w options, to allow easier integration with tools less reliant on a single anatomical scan. * ENH: Use genericised "anat" input/output for TemplateDimensions (#443) * ENH: Remove much of the hardcoded `T1w` fields in favor of `anat` (#433) * RF: Load package data with acres (#448) * RF: `space-fsaverage` to `sphere_reg` output files (#446) * MNT: Unpin libitk 5.3 (ANTs 2.5.3 is built with 5.4) (#445) * MNT: Clean up doc builds, environment, style checks (#444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a supplemental PR to nipreps/nibabies#360 - since nibabies also relies on smriprep, but may be processing in T2w space, this PR generalize many of the workflows/nodes/fields to account for other anatomical references.