Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Apr 14, 2023

This PR adds a new workflow (init_mcribs_surface_recon_wf) that can be used as an alternative to recon-all/infant_recon_all to produce anatomical surfaces.

To use this workflow, the new flag --surface-recon-method needs to be used with the option mcribs.

With the addition of this new flag, the now redundant --force-reconall flag is deprecated.
Additionally, the infantFS surface workflow was renamed to better reflect which method is being used.

To Do

  • Create brain.mgz in FreeSurfer directory (needed for recon_report)
  • Test with latest & greatest segmentations

@mgxd mgxd force-pushed the enh/mcribs-surface-processing branch from 05f7fde to a6bfa6c Compare April 14, 2023 16:46
@mgxd mgxd force-pushed the enh/mcribs-surface-processing branch from e9ecbd0 to c9231f2 Compare April 28, 2023 15:55
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage: 23.61% and project coverage change: -0.08 ⚠️

Comparison is base (9d070eb) 32.07% compared to head (90bdda8) 31.99%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   32.07%   31.99%   -0.08%     
==========================================
  Files          53       53              
  Lines        4727     4772      +45     
==========================================
+ Hits         1516     1527      +11     
- Misses       3211     3245      +34     
Impacted Files Coverage Δ
nibabies/cli/parser.py 2.11% <0.00%> (-0.10%) ⬇️
nibabies/workflows/anatomical/base.py 5.40% <0.00%> (+0.07%) ⬆️
nibabies/workflows/bold/base.py 12.89% <ø> (ø)
nibabies/workflows/bold/resampling.py 10.52% <16.66%> (-0.24%) ⬇️
nibabies/workflows/anatomical/surfaces.py 21.34% <28.94%> (+3.60%) ⬆️
nibabies/interfaces/mcribs.py 34.04% <50.00%> (+0.34%) ⬆️
nibabies/config.py 76.75% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd mgxd marked this pull request as ready for review May 1, 2023 20:49
mgxd added 9 commits May 3, 2023 23:15
@mgxd mgxd merged commit 6e2778a into master May 18, 2023
@mgxd mgxd deleted the enh/mcribs-surface-processing branch May 18, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants