FIX: Validate and summarize multi-volume sbrefs #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint/24.0.x #3320 +/- ##
================================================
+ Coverage 73.79% 73.85% +0.05%
================================================
Files 56 56
Lines 4263 4272 +9
================================================
+ Hits 3146 3155 +9
Misses 1117 1117 ☔ View full report in Codecov by Sentry. |
effigies
added a commit
that referenced
this pull request
Jul 16, 2024
24.0.1 (July 16, 2024) Bug fix release in the 24.0.x series. This release resolves a bug with multi-volume single-band references. If multiple volumes are found, they are processed in the same way as the BOLD series is processed to produce a motion-correction reference. * FIX: Validate and summarize multi-volume sbrefs (#3320) * DOC: Address errors/warnings in RTD builds (#3325) * DOC: Read html_baseurl from RTD environment, if available (#3324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Not backportable as-is, although the change is very small. To backport into 24.0.x, we could check whethersbref_files[0]is 4D, and fall back to the existing code if not.This only modifies the workflow in a known-breaking case. Safe for bug-fix releases.
Closes #3319.
Documentation that should be reviewed