Flushing channels on destroy #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Oct 17, 2024
threading/channels.nim
Outdated
| {.error: "This module requires one of --mm:arc / --mm:atomicArc / --mm:orc compilation flags".} | ||
|
|
||
| import std/[locks, isolation, atomics] | ||
| import std/[locks, isolation, atomics, options] |
There was a problem hiding this comment.
Nah. I don't like options and nothing about this new API is hardly any better than the old one:
var x: T
if tryRecv(chan, x): ...vs:
let x = tryRecv(chan)
if x.isSome: ...
|
Found some apparent problems with the compiler due to this change, distilled and reported them in nim-lang/Nim#24374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when a channel with pending messages is destroyed, a memory leak can occur if the messages themselves have non-trivial destructors. This PR aims to fix this via receiving all the pending messages during channel destruction.
Also adding
tryRecvwithOption[T}result instead of an out parameter and a boolean flag for convenience.