asyncdispatch: for NuttX, add destructor to clear global dispatcher. #21432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Feb 24, 2023
lib/pure/asyncdispatch.nim
Outdated
|
|
||
| when defined(nuttx): | ||
| proc addAtExit(quitProc: proc() {.noconv, cdecl.}) {. | ||
| importc: "atexit", header: "<stdlib.h>".} |
There was a problem hiding this comment.
It was marked "deprecated" and I thought it would go away.
when not defined(nimPreviewSlimSystem):
proc addQuitProc*(quitProc: proc() {.noconv.}) {.
importc: "atexit", header: "<stdlib.h>", deprecated: "use exitprocs.addExitProc".}There was a problem hiding this comment.
In the exitprocs, there is a "callClosures" that registers with the OS in atexit() and executes functions that the user registers.
Would it be a good idea to change it so that it executes while removing functions from the gFuns array?
(The second time the task is invoked, gFuns.len == 0, so atexit() will be executed again).
centurysys
force-pushed
the
feature/nuttx-asyncdispatch-destructor
branch
from
8647432 to
e2ba3ab
Compare
…sing atexit(). Signed-off-by: Takeyoshi Kikuchi <[email protected]>
centurysys
force-pushed
the
feature/nuttx-asyncdispatch-destructor
branch
from
e2ba3ab to
57ccf45
Compare
Signed-off-by: Takeyoshi Kikuchi <[email protected]>
|
I was able to get it to use std/exitprocs. Please confirm. |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…im-lang#21432) * asyncdispatch: for NuttX, add destructor to clear global dispatcher using atexit(). Signed-off-by: Takeyoshi Kikuchi <[email protected]> * std: exitprocs: remove "when defined(nuttx)" block. Signed-off-by: Takeyoshi Kikuchi <[email protected]> --------- Signed-off-by: Takeyoshi Kikuchi <[email protected]>
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…im-lang#21432) * asyncdispatch: for NuttX, add destructor to clear global dispatcher using atexit(). Signed-off-by: Takeyoshi Kikuchi <[email protected]> * std: exitprocs: remove "when defined(nuttx)" block. Signed-off-by: Takeyoshi Kikuchi <[email protected]> --------- Signed-off-by: Takeyoshi Kikuchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the task ends, all opened file descriptors are closed by OS, but the memory is left as it is, so the gDisp(global dispatcher) is not released and the "value" of the epoll fd inside gDisp is left as it is.
Therefore, when the task was started a second time, it judged that epoll_create1() had already been executed, resulting in an error.
For NuttX only, I was able to deal with this by explicitly registering the process of clearing gDisp with atexit() before using the asyncdispatch function.