Skip to content

Conversation

Araq
Copy link
Member

@Araq Araq commented Aug 30, 2020

don't merge yet. Todo:

  • Make new style concepts trigger implicit generics in proc p(c: MyConcept).
  • The Dictionary[K, V] concept must work.
  • Infer static T values.

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Araq Araq changed the title new-style concepts implemetion, WIP new-style concepts implementation, WIP Sep 10, 2020
@Soupertonic
Copy link

Soupertonic commented Nov 11, 2020

Hey, great work! What's the ETA for this to get merged? Super hyped for this!

@Araq
Copy link
Member Author

Araq commented Nov 12, 2020

I hoped for somebody to take over my work as it's not scheduled.

@Araq Araq added the merge_when_passes_CI mergeable once green label Feb 24, 2021
@Araq
Copy link
Member Author

Araq commented Feb 24, 2021

Will merge to keep it from bitrotting.

@Araq Araq merged commit 6278b5d into devel Feb 24, 2021
@Araq Araq deleted the araq-concepts branch February 24, 2021 12:17
ringabout pushed a commit to ringabout/Nim that referenced this pull request Mar 22, 2021
* fixes nim-lang#15210 [backport:1.2]

* make tests green
* make ordinal work
* makes Swapable test compile
* make Indexable example work
* concepts: 'self' is now 'Self'
* concepts: make Dictionary example compile
* document the new concept implementation
* concepts: make typeDesc work properly
* concepts: allow documentation comments (d'oh)
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* fixes nim-lang#15210 [backport:1.2]

* make tests green
* make ordinal work
* makes Swapable test compile
* make Indexable example work
* concepts: 'self' is now 'Self'
* concepts: make Dictionary example compile
* document the new concept implementation
* concepts: make typeDesc work properly
* concepts: allow documentation comments (d'oh)
@yrashk
Copy link

yrashk commented Aug 22, 2022

What's the plan with the new style concepts, are they still considered experimental or is there a path to maturity envisioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants