Skip to content

Migrate deprecated ESLint formatting rules to stylistic rules #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 12, 2025
Merged

Migrate deprecated ESLint formatting rules to stylistic rules #169

merged 10 commits into from
Sep 12, 2025

Conversation

gokulprasanth-ni
Copy link
Collaborator

@gokulprasanth-ni gokulprasanth-ni commented Sep 9, 2025 •
edited
Loading

Justification

Resolves #148

Implementation

  • Replaced deprecated ESLint formatting rules with their @stylistic equivalents.
  • Installed the @stylistic/eslint-plugin package and added the plugin reference in the respective files.
  • Used "plugin:@stylistic/disable-legacy", which turns off all the legacy formatting rules that have been migrated to @stylistic .
    Reference: eslint-stylistic/disable-legacy.ts

Testing

  • Packed and applied the updated style guide in our client app - linting passed successfully.
image

gokulprasanth-ni added 5 commits September 9, 2025 11:07
feat: migrate to stylistic
e2094c4 
Signed-off-by: gokulprasanth-ni <[email protected]>
Change files
498ab71
update change files
b87ca68 
Signed-off-by: gokulprasanth-ni <[email protected]>
remove unwanted rules
80dd743 
Signed-off-by: gokulprasanth-ni <[email protected]>
update change file description
31114e3 
Signed-off-by: gokulprasanth-ni <[email protected]>
vivinkrishna-ni
vivinkrishna-ni approved these changes Sep 9, 2025
View reviewed changes
refactor: address PR comments
f745a97 
Signed-off-by: gokulprasanth-ni <[email protected]>
@gokulprasanth-ni gokulprasanth-ni marked this pull request as ready for review September 9, 2025 13:04
jattasNI
jattasNI reviewed Sep 9, 2025
View reviewed changes
gokulprasanth-ni added 2 commits September 10, 2025 10:28
@gokulprasanth-ni
Copy link
Collaborator Author

@rajsite @TrevorKarjanis Gentle reminder to review this PR.

rajsite
rajsite requested changes Sep 11, 2025
View reviewed changes
gokulprasanth-ni added 2 commits September 12, 2025 09:51
update change files description
d0826b9 
Signed-off-by: gokulprasanth-ni <[email protected]>
remove @typescript-eslint/stylistic config
dfa3b79 
Signed-off-by: gokulprasanth-ni <[email protected]>
@rajsite rajsite merged commit 91e2d97 into main Sep 12, 2025
2 checks passed
@rajsite rajsite deleted the users/gokulprasanthRavi/migrate-to-stylistic branch September 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI jattasNI approved these changes

@TrevorKarjanis TrevorKarjanis Awaiting requested review from TrevorKarjanis TrevorKarjanis is a code owner

+1 more reviewer

@vivinkrishna-ni vivinkrishna-ni vivinkrishna-ni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop providing configuration for deprecated formatting rules
4 participants
@gokulprasanth-ni @rajsite @jattasNI @vivinkrishna-ni