Skip to content

Add .NET Standard 2.1 target #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 29, 2022
Merged

Add .NET Standard 2.1 target #3050

merged 7 commits into from
Aug 29, 2022

Conversation

@hazzik
Copy link
Member

@hazzik hazzik commented Apr 27, 2022

No description provided.

@bahusoid
Copy link
Member

bahusoid commented Apr 27, 2022 •
edited
Loading

Similarly to #3000 will cause intermittent (quite often) failure builds like #3000 (comment)

@hazzik
Copy link
Member Author

hazzik commented Aug 24, 2022

Similarly to #3000 will cause intermittent (quite often) failure builds like #3000 (comment)

I've set maxcpucount to 1, so it should help. However, builds might become slower.

@hazzik hazzik changed the base branch from master to generate-async-code August 25, 2022 00:12
@hazzik hazzik deleted the branch nhibernate:master August 25, 2022 08:41
@hazzik hazzik closed this Aug 25, 2022
@hazzik hazzik reopened this Aug 25, 2022
@hazzik hazzik changed the base branch from generate-async-code to master August 25, 2022 10:54
@hazzik
Copy link
Member Author

hazzik commented Aug 26, 2022

However, builds might become slower.

Seems the same time.

fredericDelaporte
fredericDelaporte reviewed Aug 27, 2022
View reviewed changes
hazzik added 2 commits August 28, 2022 21:47
@hazzik
Update NHibernate.csproj
e3927d0 
Fix whitespaces and minimize changes
@hazzik
Invert condition
63f75a3
@hazzik hazzik enabled auto-merge (squash) August 28, 2022 23:30
@hazzik hazzik added this to the next minor milestone Aug 28, 2022
@hazzik hazzik merged commit 8e22b70 into nhibernate:master Aug 29, 2022
@hazzik hazzik deleted the netstandard2.1 branch August 29, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

@bahusoid bahusoid Awaiting requested review from bahusoid

Assignees

No one assigned

Labels

c: Core p: Lowest r: Fixed t: Improvement

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@hazzik @bahusoid @fredericDelaporte