Allow disabling Firebird driver parameter casting #1892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
firebirdDriverConfigSqlHack
branch
from
449ba52 to
16fabdf
Compare
| </xs:documentation> | ||
| </xs:annotation> | ||
| </xs:enumeration> | ||
| <xs:enumeration value="firebird.disable_parameter_casting"> |
Member
Author
There was a problem hiding this comment.
For such database/driver specific parameters, like oracle.use_n_prefixed_types_for_unicode or odbc.explicit_datetime_scale, I wonder if we should put in place a "catch them all" solution, similar to what is done for cache.* parameters. Something like database_specific.*.
But then, they will be less discoverable.
Member
There was a problem hiding this comment.
Unlike the cache, this is driving from inside the library, so should be fine as it is.
hazzik
previously approved these changes
Oct 29, 2018
The NHibernate Firebird driver does hack SQL commands for explicitly casting their parameters. This may cause issues in some cases, while, depending on the application, it may not be required. See nhibernate#1886.
fredericDelaporte
force-pushed
the
firebirdDriverConfigSqlHack
branch
from
16fabdf to
b238c3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NHibernate Firebird driver does hack SQL commands for explicitly casting their parameters. This may cause issues in some cases, while, depending on the application, it may not be required. See #1886.