StackOverflowException when merging an entity with a lazy property

[offan]

When you call Merge, you may get a StackOverflowException. Test added. May be corrected by a change in the file PocoEntityTuplizer, in the method HasUninitializedLazyProperties:

if (EntityMetamodel.HasLazyProperties 
    // add this
    && !(entity is IProxy))

But I do not know if it is correct or not.

[offan]

broken link

Сommit a new branch with the added test
Permission to nhibernate/nhibernate-core.git denied to offan

post here test.

class LazyPropertyFixture

            [Test]
	public void CanMergeWithLazyProperty()
	{
		using (ISession s = OpenSession())
		using (var tx = s.BeginTransaction())
		{
			var book = new Book
			{
		            Name = "some name two",
                                Id = 2,
                                ALotOfText = "a lot of text ..." 
			}
                            s.Merge(book);
			tx.Commit();
		}
		using (ISession s = OpenSession())
		{
			book = s.Get<Book>(2);
			Assert.That(book, Is.Not.Null);
		}
	}

[fredericDelaporte]

Thanks for the reports, readme file is now fixed.

You cannot push directly to NHibernate repository. You need to first fork it as one of your own repositories (Fork button is normally in upper right corner of GitHub pages), clone your own repository locally (instead of the NHibernate one), create a branch on it, commit then push to your own repository fork, then PR from it.

[offan]

repo: https://github.com/offan/nhibernate-core
branch GH1436

[fredericDelaporte]

We are working with pull requests (PR). Issue a PR from your branch toward nhibernate repository master branch.