Skip to content

Remove redundant Cast calls #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove redundant Cast calls #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/FluentNHibernate/Conventions/Inspections/AnyInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ public IEnumerable<IColumnInspector> IdentifierColumns
get
{
return mapping.IdentifierColumns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}

Expand All @@ -51,8 +50,7 @@ public IEnumerable<IMetaValueInspector> MetaValues
get
{
return mapping.MetaValues
.Select(x => new MetaValueInspector(x))
.Cast<IMetaValueInspector>();
.Select(x => new MetaValueInspector(x));
}
}

Expand All @@ -63,8 +61,7 @@ public IEnumerable<IColumnInspector> TypeColumns
get
{
return mapping.TypeColumns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}

Expand Down
18 changes: 6 additions & 12 deletions src/FluentNHibernate/Conventions/Inspections/ClassInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public IEnumerable<IAnyInspector> Anys
get
{
return mapping.Anys
.Select(x => new AnyInspector(x))
.Cast<IAnyInspector>();
.Select(x => new AnyInspector(x));
}
}

Expand All @@ -88,8 +87,7 @@ public IEnumerable<ICollectionInspector> Collections
get
{
return mapping.Collections
.Select(x => new CollectionInspector(x))
.Cast<ICollectionInspector>();
.Select(x => new CollectionInspector(x));
}
}

Expand All @@ -113,8 +111,7 @@ public IEnumerable<IJoinInspector> Joins
get
{
return mapping.Joins
.Select(x => new JoinInspector(x))
.Cast<IJoinInspector>();
.Select(x => new JoinInspector(x));
}
}

Expand All @@ -123,8 +120,7 @@ public IEnumerable<IOneToOneInspector> OneToOnes
get
{
return mapping.OneToOnes
.Select(x => new OneToOneInspector(x))
.Cast<IOneToOneInspector>();
.Select(x => new OneToOneInspector(x));
}
}

Expand All @@ -133,17 +129,15 @@ public IEnumerable<IPropertyInspector> Properties
get
{
return mapping.Properties
.Select(x => new PropertyInspector(x))
.Cast<IPropertyInspector>();
.Select(x => new PropertyInspector(x));
}
}
public IEnumerable<IManyToOneInspector> References
{
get
{
return mapping.References
.Select(x => new ManyToOneInspector(x))
.Cast<IManyToOneInspector>();
.Select(x => new ManyToOneInspector(x));
}
}

Expand Down
15 changes: 5 additions & 10 deletions src/FluentNHibernate/Conventions/Inspections/ComponentBaseInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ public IEnumerable<IAnyInspector> Anys
get
{
return mapping.Anys
.Select(x => new AnyInspector(x))
.Cast<IAnyInspector>();
.Select(x => new AnyInspector(x));
}
}

Expand All @@ -56,8 +55,7 @@ public IEnumerable<ICollectionInspector> Collections
get
{
return mapping.Collections
.Select(x => new CollectionInspector(x))
.Cast<ICollectionInspector>();
.Select(x => new CollectionInspector(x));
}
}

Expand Down Expand Up @@ -89,8 +87,7 @@ public IEnumerable<IOneToOneInspector> OneToOnes
get
{
return mapping.OneToOnes
.Select(x => new OneToOneInspector(x))
.Cast<IOneToOneInspector>();
.Select(x => new OneToOneInspector(x));
}
}

Expand All @@ -99,8 +96,7 @@ public IEnumerable<IPropertyInspector> Properties
get
{
return mapping.Properties
.Select(x => new PropertyInspector(x))
.Cast<IPropertyInspector>();
.Select(x => new PropertyInspector(x));
}
}

Expand All @@ -109,8 +105,7 @@ public IEnumerable<IManyToOneInspector> References
get
{
return mapping.References
.Select(x => new ManyToOneInspector(x))
.Cast<IManyToOneInspector>();
.Select(x => new ManyToOneInspector(x));
}
}

Expand Down
6 changes: 2 additions & 4 deletions src/FluentNHibernate/Conventions/Inspections/CompositeElementInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ public IEnumerable<IPropertyInspector> Properties
get
{
return mapping.Properties
.Select(x => new PropertyInspector(x))
.Cast<IPropertyInspector>();
.Select(x => new PropertyInspector(x));
}
}

Expand All @@ -53,8 +52,7 @@ public IEnumerable<IManyToOneInspector> References
get
{
return mapping.References
.Select(x => new ManyToOneInspector(x))
.Cast<IManyToOneInspector>();
.Select(x => new ManyToOneInspector(x));
}
}
}
6 changes: 2 additions & 4 deletions src/FluentNHibernate/Conventions/Inspections/CompositeIdentityInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ public IEnumerable<IKeyManyToOneInspector> KeyManyToOnes
{
return mapping.Keys
.Where(x => x is KeyManyToOneMapping)
.Select(x => new KeyManyToOneInspector((KeyManyToOneMapping)x))
.Cast<IKeyManyToOneInspector>();
.Select(x => new KeyManyToOneInspector((KeyManyToOneMapping)x));
}
}

Expand All @@ -47,8 +46,7 @@ public IEnumerable<IKeyPropertyInspector> KeyProperties
{
return mapping.Keys
.Where(x => x is KeyPropertyMapping)
.Select(x => new KeyPropertyInspector((KeyPropertyMapping)x))
.Cast<IKeyPropertyInspector>();
.Select(x => new KeyPropertyInspector((KeyPropertyMapping)x));
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/ElementInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/IdentityInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(EntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(EntityType, x));
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/IndexInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}
}
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/IndexManyToManyInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}
}
12 changes: 4 additions & 8 deletions src/FluentNHibernate/Conventions/Inspections/JoinInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ public IEnumerable<IAnyInspector> Anys
get
{
return mapping.Anys
.Select(x => new AnyInspector(x))
.Cast<IAnyInspector>();
.Select(x => new AnyInspector(x));
}
}

Expand All @@ -56,8 +55,7 @@ public IEnumerable<IPropertyInspector> Properties
get
{
return mapping.Properties
.Select(x => new PropertyInspector(x))
.Cast<IPropertyInspector>();
.Select(x => new PropertyInspector(x));
}
}

Expand All @@ -66,8 +64,7 @@ public IEnumerable<IManyToOneInspector> References
get
{
return mapping.References
.Select(x => new ManyToOneInspector(x))
.Cast<IManyToOneInspector>();
.Select(x => new ManyToOneInspector(x));
}
}

Expand All @@ -77,8 +74,7 @@ public IEnumerable<ICollectionInspector> Collections
get
{
return mapping.Collections
.Select(x => new CollectionInspector(x))
.Cast<ICollectionInspector>();
.Select(x => new CollectionInspector(x));
}
}

Expand Down
23 changes: 8 additions & 15 deletions src/FluentNHibernate/Conventions/Inspections/JoinedSubclassInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ public IEnumerable<IAnyInspector> Anys
get
{
return mapping.Anys
.Select(x => new AnyInspector(x))
.Cast<IAnyInspector>();
.Select(x => new AnyInspector(x));
}
}

Expand All @@ -56,8 +55,7 @@ public IEnumerable<ICollectionInspector> Collections
get
{
return mapping.Collections
.Select(x => new CollectionInspector(x))
.Cast<ICollectionInspector>();
.Select(x => new CollectionInspector(x));
}
}

Expand Down Expand Up @@ -87,8 +85,7 @@ public IEnumerable<IJoinInspector> Joins
get
{
return mapping.Joins
.Select(x => new JoinInspector(x))
.Cast<IJoinInspector>();
.Select(x => new JoinInspector(x));
}
}

Expand All @@ -103,8 +100,7 @@ public IEnumerable<IOneToOneInspector> OneToOnes
get
{
return mapping.OneToOnes
.Select(x => new OneToOneInspector(x))
.Cast<IOneToOneInspector>();
.Select(x => new OneToOneInspector(x));
}
}

Expand All @@ -113,8 +109,7 @@ public IEnumerable<IPropertyInspector> Properties
get
{
return mapping.Properties
.Select(x => new PropertyInspector(x))
.Cast<IPropertyInspector>();
.Select(x => new PropertyInspector(x));
}
}

Expand All @@ -125,8 +120,7 @@ public IEnumerable<IManyToOneInspector> References
get
{
return mapping.References
.Select(x => new ManyToOneInspector(x))
.Cast<IManyToOneInspector>();
.Select(x => new ManyToOneInspector(x));
}
}
public bool SelectBeforeUpdate => mapping.SelectBeforeUpdate;
Expand All @@ -136,12 +130,11 @@ public IEnumerable<IJoinedSubclassInspector> Subclasses
get
{
return mapping.Subclasses
.Select(x => new JoinedSubclassInspector(x))
.Cast<IJoinedSubclassInspector>();
.Select(x => new JoinedSubclassInspector(x));
}
}

IEnumerable<ISubclassInspectorBase> ISubclassInspectorBase.Subclasses => Subclasses.Cast<ISubclassInspectorBase>();
IEnumerable<ISubclassInspectorBase> ISubclassInspectorBase.Subclasses => Subclasses;

public string TableName => mapping.TableName;

Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/KeyInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/KeyManyToOneInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}
}
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/KeyPropertyInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}
public int Length => mapping.Length;
Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/ManyToManyInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/FluentNHibernate/Conventions/Inspections/ManyToOneInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ public IEnumerable<IColumnInspector> Columns
get
{
return mapping.Columns
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x))
.Cast<IColumnInspector>();
.Select(x => new ColumnInspector(mapping.ContainingEntityType, x));
}
}

Expand Down
Loading