QuickJS-NG: Add discovery via pkg-config + add compat for different JS_IsError signature #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 57fffbbb6a98b316e5195ff31655cd13db2bfa5b ("Remove unused JSContext
argument from JS_IsError")[1], QuickJS-NG's JS_IsError() takes only the
value parameter, no context.
[1]: quickjs-ng/quickjs@57fffbb
Signed-off-by: Zurab Kvachadze <[email protected]>
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
I have hereby read the F5 CLA and agree to its terms |
Author
|
I have hereby read the F5 CLA and agree to its terms |
BalkanMadman
force-pushed
the
quickjs-ng
branch
from
b60b325 to
397f7ab
Compare
In QuickJS-NG since 8e671eb8e59f5f5d7eca111386fbe158fab09049 ("build:
initial support for meson build system")[1], Meson can be used as a
build system, generating .pc (pkg-config) modules. This commit adds
another method of QuickJS-NG discovery using pkg-config.
[1]: quickjs-ng/quickjs@8e671eb
Signed-off-by: Zurab Kvachadze <[email protected]>
BalkanMadman
force-pushed
the
quickjs-ng
branch
from
397f7ab to
b31b34a
Compare
Author
|
Fixed |
Contributor
|
Hi @BalkanMadman, Thank you for the patch. Please, take a look at my attempt here #989. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch series fixes certain bits related to QuickJS-NG.
ctxparameter from theJS_IsErrorfunction around a month ago in quickjs-ng/quickjs@57fffbb. The first commit of this PR adds a shim macro toquickjs_compat.hthat, if QUICKJS_NG is used, definesJS_IsError(ctx, val)toJS_IsError(val).Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument