Skip to content

nginx-sys: define ngx_list_init #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

pchickey
Copy link
Contributor

@pchickey pchickey commented Jun 23, 2025

Like many of the functions defined in nginx-sys, ngx_list_init is defined in nginx as an inline function in a C header, so it isnt captured by bindgen. This definition is equivalent to the one in the C header: https://github.com/nginx/nginx/blob/master/src/core/ngx_list.h#L36-L52

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue
on GitHub, make sure to include a link to that issue here in this description
(not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

like many of the functions defined in nginx-sys, this is defined in
nginx as an inline function in a C header, so it isnt captured by
bindgen.
@pchickey pchickey force-pushed the pch/add_ngx_list_init branch from d48e11a to e07a0a6 Compare June 24, 2025 17:06
@pchickey pchickey requested a review from bavshin-f5 June 24, 2025 17:06
Copy link
Member

@bavshin-f5 bavshin-f5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bavshin-f5 bavshin-f5 merged commit d2fe67e into nginx:master Jun 24, 2025
15 checks passed
@pchickey pchickey deleted the pch/add_ngx_list_init branch June 24, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants