Skip to content

Improved docs on accept_mutex_delay #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muhammedsirajudeen
Copy link

Proposed changes

While reading the docs especially the accept_mutex_delay section the sentence there bugged me quiet a bit. So I just added two words that would make reading that it a bit more easier

If [accept_mutex](https://nginx.org/en/docs/ngx_core_module.html#accept_mutex) is enabled, specifies the maximum time during which a worker process will try to restart accepting new connections if another worker process is currently accepting new connections.

to

If [accept_mutex](https://nginx.org/en/docs/ngx_core_module.html#accept_mutex) is enabled, **this directive** specifies the maximum time during which a worker process will try to restart accepting new connections if another worker process is currently accepting new connections.

Part of documentation

I know this is isnt a big deal but it kinda bugged me a lot while reading it.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@pluknet
Copy link
Collaborator

pluknet commented Aug 12, 2025

It is a fairly common wording in nginx; taking even the next directive(s) after it in the list:

<directive name="daemon">
...
Determines whether nginx should become a daemon.

<directive name="debug_connection">
...
Enables debugging log for selected client connections.

<directive name="load_module">
...
Loads a dynamic module.

accept_mutex_delay fits in quite well with them, up to the clarifying phrase in the beginning.

Adding "this directive" to all of them would make a small clarification benefit;
on the other side, this will compromise the compactness of the text wording.
I'd rather not, thanks.

@pluknet pluknet closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants