Skip to content

fix: update SCC #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: update SCC #97

merged 1 commit into from
Apr 13, 2023

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Apr 13, 2023 •
edited
Loading

Proposed changes

Fix the SCC to reflect changes in NGINX Ingress Controller v3.1.0.

See https://github.com/nginxinc/kubernetes-ingress/pull/3629/files and https://github.com/nginxinc/kubernetes-ingress/pull/3573/files

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner April 13, 2023 09:36
@github-actions github-actions bot added the bug An issue reporting a potential bug label Apr 13, 2023
shaun-nx
shaun-nx approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ciarams87 ciarams87 merged commit e7d30ba into main Apr 13, 2023
@ciarams87 ciarams87 deleted the fix/update-scc branch April 13, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciarams87 @vepatel @shaun-nx