Skip to content

feat: Update for NIC v3.1.0 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2023
Merged

feat: Update for NIC v3.1.0 #93

merged 1 commit into from
Apr 3, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Update operator based on v0.17.0 of the NIC Helm chart

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner March 28, 2023 10:33
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 28, 2023
@ciarams87 ciarams87 force-pushed the update-for-nic-3.1.0 branch 2 times, most recently from d768dc8 to bc7e90f Compare March 28, 2023 12:06
lucacome
lucacome approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you took care of the changes in #86 with this one, right?

@ciarams87 ciarams87 force-pushed the update-for-nic-3.1.0 branch from bc7e90f to 2a093ac Compare April 3, 2023 13:57
@ciarams87
Copy link
Contributor Author

ciarams87 commented Apr 3, 2023 •
edited
Loading

I think you took care of the changes in #86 with this one, right?

Yep, I did @lucacome!

@ciarams87 ciarams87 enabled auto-merge (squash) April 3, 2023 13:58
@ciarams87 ciarams87 merged commit c5c0cc5 into main Apr 3, 2023
@ciarams87 ciarams87 deleted the update-for-nic-3.1.0 branch April 3, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @lucacome @jjngx @shaun-nx