Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 3, 2025

Proposed changes

  • Change to F5 runners for release builds
  • Separate release workflow
  • Have e2e tests run against image built

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 3, 2025
@pdabelf5 pdabelf5 marked this pull request as ready for review October 3, 2025 09:53
@pdabelf5 pdabelf5 requested a review from a team as a code owner October 3, 2025 09:53
Copilot AI review requested due to automatic review settings October 3, 2025 09:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the GitHub Actions runner configuration to use F5 self-hosted runners for release builds while keeping standard Ubuntu runners for pull requests. The changes split CI and release functionality, introducing a dedicated release workflow and optimizing the existing CI workflow.

  • Introduces a new dedicated release workflow with F5 runners for operator releases
  • Updates CI workflow to conditionally use F5 runners for non-PR builds
  • Removes tag-based triggers and certification steps from the main CI workflow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/release-operator.yml New dedicated workflow for operator releases using F5 runners
.github/workflows/ci.yml Updated to conditionally use F5 runners and removed release-specific functionality
.github/workflows/e2e-test.yml Added image existence check and conditional build steps for testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pdabelf5 pdabelf5 self-assigned this Oct 3, 2025
@pdabelf5 pdabelf5 moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller Oct 3, 2025
@pdabelf5 pdabelf5 merged commit e6df726 into main Oct 7, 2025
7 checks passed
@pdabelf5 pdabelf5 deleted the chore/publish-runner branch October 7, 2025 09:00
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

5 participants