Skip to content

update clusterrole and roles #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 17, 2024
Merged

update clusterrole and roles #436

merged 5 commits into from
Dec 17, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Dec 17, 2024 •
edited
Loading

Proposed changes

  • Update roles to clusterroles to facilitate lease management
  • Update IC roles for prod telemetry

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Dec 17, 2024
@vepatel vepatel marked this pull request as ready for review December 17, 2024 15:13
@vepatel vepatel requested a review from a team as a code owner December 17, 2024 15:13
@vepatel vepatel changed the title update clusterrole update clusterrole and roles Dec 17, 2024
@vepatel vepatel merged commit c7687f3 into main Dec 17, 2024
7 checks passed
@vepatel vepatel deleted the fix/rabc branch December 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vepatel @AlexFenlon @jjngx @pdabelf5